Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting of <conditional>s #3464

Merged
merged 1 commit into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Jan 23, 2017

If the first param is boolean with truevalue="True" or falsavalue="False", or a select with an option having value True or False, the linter was wrongly complaining with both:

No <when /> block found for select option 'True'

and:

No <option /> block found for when block 'true'

Tested on all tools shipped with Galaxy and most of tools-iuc tools.

Fix linting of <conditional>s
If the first param is boolean with truevalue="True" or falsavalue="False",
or a select with an option having value "True" or "False", the linter was
wrongly complaining with both:

No <when /> block found for select option 'True'

and:

No <option /> block found for when block 'true'

@nsoranzo nsoranzo added this to the 17.01 milestone Jan 23, 2017

@jmchilton jmchilton merged commit 8daa58a into galaxyproject:dev Jan 23, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 135 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jan 23, 2017

Great - definitely time to do some planemo work with all the latest XSD, linting, and Conda goodies.

@nsoranzo nsoranzo deleted the nsoranzo:conditional_linting branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.