Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple UI to manage tool dependencies #3479

Merged
merged 6 commits into from Mar 8, 2017

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Jan 24, 2017

This page simply lists all loaded tools and their dependency status.
On the left are checkboxes to select multiple tools, and at the bottom
is a button to install the selected tool dependencies.

Ping @martenson

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2017

screen shot 2017-01-24 at 10 48 19 pm

@martenson martenson self-assigned this Jan 24, 2017

@galaxybot galaxybot added this to the 17.05 milestone Jan 24, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2017

I've added another view that focuses on dependency environments.
screen shot 2017-01-26 at 5 33 35 pm
I think that's quite useful to keep track of what is using the all-in-one resolution and what would benefit from caching (which I will also add, now that I'm already on it ...)

@martenson
Copy link
Member

left a comment

I fixed a forgotten </div> that prevented it from rendering properly and tried to improve UX a bit. The functionality works for me and will be useful to admins I believe.

@mvdbeek could you please add a short summary to the top of the page that explains what the user sees and can do and why? I tried to come up with something but I am bad at explaining things I don't understand well. ;)

mvdbeek and others added some commits Jan 24, 2017

Add a simple UI to manage tool dependencies
This page simply lists all loaded tools and their dependency status.
On the left are checkboxes to select multiple tools, and at the bottom
is a button to install the selected tool dependencies.
Build the dependency status more efficiently: Pass a dictionary with …
…ToolRequirements object as key and requirements status as value

@mvdbeek mvdbeek force-pushed the mvdbeek:manage_tool_dependencies branch from cb8d6e4 to 5dc73b7 Mar 8, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2017

@martenson is it sth like this that you had in mind?
screen shot 2017-03-08 at 12 09 35 pm

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2017

@galaxybot test this

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

@mvdbeek Yes, thanks!

Also what happens when you install non-TS dependency using Conda? Does it also follow the resolver conf?

@martenson martenson merged commit 0118c57 into galaxyproject:dev Mar 8, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2017

Also what happens when you install non-TS dependency using Conda? Does it also follow the resolver conf?

Yes, the same rules apply. The critical part through the code is the same then the one that is being followed when you run a job.

@mvdbeek mvdbeek deleted the mvdbeek:manage_tool_dependencies branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.