Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test for default Conda mapping. #3508

Merged
merged 2 commits into from Jan 30, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Jan 27, 2017

It worked locally simply because I had R already installed on my system globally.

Ping @mvdbeek - I know you are working on the mapping stuff so I'm pinging you in case you run into the same testing bug.

jmchilton added some commits Jan 27, 2017

Fix integration test for default Conda mapping.
It worked locally simply because I had R already installed on my system globally.
@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jan 27, 2017

huh, I hadn't noticed this, we should really be running those integration tests!
👍

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2017

It is a bit of a chicken and egg problem with these tests (integration and Selenium). I can't fix them fast enough to keep them stable long enough to feel confident enable PR checking.

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jan 27, 2017

But if you enable them we can adjust them if we want to get the PR merged warranted ... :).

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2017

@galaxybot test this

@dannon dannon merged commit 4eb770d into galaxyproject:dev Jan 30, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 137 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.