Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken tour step. #3582

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Feb 8, 2017

This causes the Selenium tests to fail under various conditions - but legitimately so. The referenced target link disappears pretty quickly after the step in the previous click. When I run them in the web browser and this step is "disconnected" and in the center of the screen and as a result it isn't clear what links are being referred to.

I'm open to other fixes - removing this step was just the most obvious things. Let me know.

Remove broken tour step.
This causes the Selenium tests to fail under various conditions - but legimately so. The referenced target link disappears pretty quickly after the step in the previous click. When I run them in the web browser and this step is "disconnected" and in the center of the screen and as a result it isn't clear what links are being referred to.
@martenson

This comment has been minimized.

Copy link
Member

commented Feb 9, 2017

I went through that tour on Main and besides multiple inconsistencies and confusions this one seems fairly heavy:

screenshot 2017-02-09 10 32 43

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2017

I agree the tour is broken or flakey in other ways as well - can we make an issue for that rather than holding up this pull request? Alternatively I can disable the test for this tour if you'd prefer - I'd like to make progress toward enabling the selenium tests though.

@dannon

This comment has been minimized.

Copy link
Member

commented Feb 9, 2017

I'm fine with just dropping this step.

@dannon dannon merged commit be09b7c into galaxyproject:dev Feb 9, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 138 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2017

Thanks for the merge @dannon!

@martenson

This comment has been minimized.

Copy link
Member

commented Feb 9, 2017

@jmchilton I wasn't about to hold this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.