Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate user disk usage on logout. #3600

Merged
merged 3 commits into from Feb 14, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Feb 12, 2017

Not as ideal as just having it be accurate all the time, but it 1) avoids adding yet another control people need to dig for when they need to recalculate, and 2) makes things right when following 'turn it off and on again'

Recalculate user disk usage on logout. Not as ideal as just having it…
… be accurate all the time, but it 1) avoids adding yet another control people need to dig for when they need to recalculate, and 2) makes things right when following 'turn it off and on again'

@galaxybot galaxybot added the triage label Feb 12, 2017

@galaxybot galaxybot added this to the 17.05 milestone Feb 12, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2017

Adding a hint on the quota meter tooltip that if it seems incorrect, log out and back in.

@martenson

This comment has been minimized.

Copy link
Member

commented Feb 12, 2017

@dannon what about adding this on login too?

edit: good idea btw

@dannon

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2017

I thought about that, on login, but it's not super fast so I figured it would bother people less on logout. What do folks think? We can try it, I just don't want it to slow down the login/getting-started feeling.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2017

(it occurs to me that we could consider this a 'fix' for the 'bug' where user disk space gets out of whack all the time, so we could also backport it to get it live on main/elsewhere if people like it)

@martenson martenson merged commit df22e40 into galaxyproject:dev Feb 14, 2017

0 of 5 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
toolshed test Test started.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Feb 14, 2017

I wonder why this PR never ran the jenkins suite... we could have found the TS fails :(

@dannon

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2017

Good question, we should probably figure that out! :) In any event, I updated the other PR with an extra check for user, and we can merge forward, and test should work fine from that point.

@jennaj

This comment has been minimized.

Copy link
Member

commented Mar 10, 2017

When this goes to Main, could we note that here so end-users know when it is active? Many are following this ticket. Thanks!

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 10, 2017

@jennaj I think it is on Main already.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2017

@jennaj @martenson is right -- this code is on main. Subsequent improvements and fixes to the functionality are not, yet. Some of those are in #3669, and others are in #3734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.