Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set 'deleted' to True when purging a history dataset association" #3613

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Feb 14, 2017

Reverts #3572

@martenson

This comment has been minimized.

Copy link
Member

commented Feb 14, 2017

This will break instances that were already migrated since they cannot downgrade.

@natefoo

This comment has been minimized.

Copy link
Member

commented Feb 14, 2017

This is a dev change so I don't think that is a problem we need to consider.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2017

Right, in -dev, someone can just check out $REV-1, downgrade, then pull new changes.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2017

(closed per discussion in #3572)

@martenson martenson deleted the revert-3572-fix_3548 branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.