Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve interaction between job state and purged datasets. #3619
There are two basic behavior changes here and bunch of testing to verify the new behaviors.
These are tackled as a pair because I assume the difference in the behaviors between deletion and purging was a hack around tools populating datasets that had been purged while running. Cancelling the job wasn't a sure fix - but it would reduce the likelihood of such problems. I think the new approach is a bit more robust and explicit.
Additionally there are a couple small, atomic commits that cleanup a couple things related to jobs before tackling this.
All new tests (and a couple old ones) can be executed using the command: