Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
More, Better XML Macros #362
There are two primary improvements here.
I think together these changes represent a more generic solution to the problem with Docker volumes being addressed with Intel-HSS#28. These should allow building a generic destination for various Intel clusters with simple parameters for the things that change between destination (maybe just resource allocations).
More on paramerization of XML macros:
This comes in two modes - simple lists of required attributes and per-attribute parameters that may specify defaults.
The following toy example:
will evaluate to
Parameters can also be defined individual to specify default values. So the following example:
Would evaluate to
referenced this pull request
Jun 17, 2015
@erasche My intuition tells me that if we only picked one there would crop up a situation where that choice would be awkward - though I cannot think of many specific contexts where @ symbols are used like this. So I might be keen to drop the
One way in which I would probably use the two token types - is to stick with
Though you know what -
1 similar comment
Right, I see that it was renamed from load_tool to load. I don't particularly like this new organization at all since it seems like we've just shoved everything into a macros module when a lot of it seems higher level than macro interpretation, but I'm a -0, so that's fine.
@jmchilton It's fine. There isn't much I'd pull out, but that the root 'load_tool' actually comes from the macros module seems off; load_tool, raw_tool_xml_tree, set_children, replace, etc., should remain in the more general tool loader class IMO. Merging anyway.