Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] By default, do not allow workflow invocations to schedule indefinitely. #3659

Conversation

Projects
None yet
5 participants
@jmchilton
Copy link
Member

commented Feb 23, 2017

Give up after a month but allow admins to reduce this amount as well.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

Is that a workaround for the problem manifested by log messages like:

Workflow step 1585 of invocation 554 delayed

?

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Feb 23, 2017

Those lines don't necessarily indicate there is a problem but this would prevent the same workflow invocation from generating those lines for over a month I guess.

I plan to follow up tomorrow with another PR that will add an end to that sentence to indicate why the workflow is being delayed - it can help admins determine if there is a problem - because I suspect in many cases there is not.

@jmchilton jmchilton force-pushed the jmchilton:1701_maximum_workflow_invocation_duration branch 2 times, most recently from c20cb6e to 14a347a Feb 24, 2017

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

@galaxybot test this

@jmchilton jmchilton force-pushed the jmchilton:1701_maximum_workflow_invocation_duration branch from 14a347a to b33b3c1 Mar 27, 2017

@jmchilton jmchilton changed the title [WIP][17.01] By default, do not allow workflow invocations to schedule indefinitely. [17.01] By default, do not allow workflow invocations to schedule indefinitely. Mar 27, 2017

@jmchilton jmchilton added status/review and removed status/WIP labels Mar 27, 2017

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2017

Rebased a fix for the failing test and pulling this one out of WIP.

@martenson
Copy link
Member

left a comment

lgtm

[17.01] By default, do not allow workflow invocations to schedule ind…
…efinitely.

Give up after a month but allow admins to reduce this amount as well.

@jmchilton jmchilton force-pushed the jmchilton:1701_maximum_workflow_invocation_duration branch from b33b3c1 to 4beb98e Mar 30, 2017

@dannon dannon merged commit 8f8526b into galaxyproject:release_17.01 Mar 30, 2017

5 checks passed

api test Build finished. 257 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Mar 30, 2017

This PR was merged without a milestone attached.

@martenson martenson added this to the 17.05 milestone Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.