Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the mzData datatype #3661

Merged
merged 2 commits into from Feb 24, 2017

Conversation

Projects
None yet
6 participants
@lecorguille
Copy link
Member

commented Feb 24, 2017

It will be used in our metabolomics workflow (w4m) but I added it into proteomics lib to join its mates

There isn't specific edam format for mzData. I used the upper class Mass spectrometry data format id

Thanks

@lecorguille lecorguille referenced this pull request Feb 24, 2017

Closed

Mention the different format/datatype allow in xcmsSet #39

2 of 4 tasks complete

@galaxybot galaxybot added the triage label Feb 24, 2017

@galaxybot galaxybot added this to the 17.05 milestone Feb 24, 2017

@bgruening

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

@odoppelt is the EDAM annotation correct or should be better remove it?

@odoppelt

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

it seems to be the right edam annotation.

@bgruening

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

Thanks @odoppelt!!!

@bgruening bgruening merged commit d5e4dc4 into galaxyproject:dev Feb 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lecorguille

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2017

Thanks @bgruening and @odoppelt :)

@lecorguille lecorguille deleted the lecorguille:datatype_mzdata branch Feb 24, 2017

@lecorguille

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2017

Hi,
Is it possible to backport this PR on some recent releases?

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

That's not a bugfix, so generally no, sorry! It should be pretty easy for you to apply it as a patch, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.