Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display an error message when IE loading raises an exception #3662

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
4 participants
@natefoo
Copy link
Member

commented Feb 24, 2017

Not sure how people feel about the use of the message mako here but otherwise you just get an empty middle panel or scratchbook window with no indication that anything has failed, and so you sit there assuming something will eventually happen if you wait long enough.

@natefoo natefoo force-pushed the natefoo:ie-error-message branch from 66c0556 to 585c107 Feb 24, 2017

@galaxybot galaxybot added this to the 17.05 milestone Feb 24, 2017

@erasche

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

I'm fine with it, definitely better than the alternative. @bgruening

@bgruening

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

👍 from me as well!

@bgruening bgruening merged commit a5ea106 into galaxyproject:dev Feb 24, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.