Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Logout recalc improvements #3669

Merged

Conversation

Projects
None yet
6 participants
@dannon
Copy link
Member

commented Feb 24, 2017

Two changes to quota-recalc-on-logout.

  1. uses pgcalc where possible for faster postgres updates
  2. makes it async, using the built in queues.

Applied to 17.01 because it's basically a bugfix because unlike my dev instance where I first wrote the functionality, on main and other large production instances, it takes years to log out without this :(

xref: #3600

@dannon dannon requested a review from bgruening Feb 24, 2017

@dannon dannon changed the title Logout recalc improvements [17.01] Logout recalc improvements Feb 24, 2017

@dannon dannon requested a review from nsoranzo Feb 24, 2017

@galaxybot galaxybot added the triage label Feb 24, 2017

@bgruening
Copy link
Member

left a comment

Works for me!

@bgruening

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

Thanks Dannon!

@@ -18,6 +19,21 @@
log = logging.getLogger(__name__)


def queue_async_task(app, task, kwargs={}):
log.info("Queuing async task %s." % task)

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek Feb 25, 2017

Member

I think the name and lack of docstring in this and send_control_task was confusing me for a moment:
The difference between send_control_task and queue_async_task is that queue_async_task is consumed just once by the same process, right? I'm asking because I think send_control_task also queues async tasks, with the difference that they are consumed by all processes (or all except the current process). If I understand this correctly it may be better to call this send_local_control_task ?

This comment has been minimized.

Copy link
@dannon

dannon Feb 25, 2017

Author Member

Yes, and, yes.

Thanks @mvdbeek, I'll add better (some!) documentation and I like the new name for the method, will update.

@martenson

This comment has been minimized.

Copy link
Member

commented Feb 25, 2017

I think it would be worth to mention the logout recalc feature in the 17.01 release notes.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Feb 27, 2017

Works for me too, thanks @dannon!

@nsoranzo nsoranzo merged commit d4b677b into galaxyproject:release_17.01 Feb 27, 2017

5 checks passed

api test Build finished. 257 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.