Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip broken autocomplete feature, webbrowsers console error is an artifact #3676

Merged
merged 2 commits into from Feb 28, 2017

Conversation

Projects
None yet
4 participants
@guerler
Copy link
Contributor

commented Feb 27, 2017

Fixes #3675. The autocomplete feature has been disabled awhile ago, the outdated autocomplete front-end plugin causes an artifact console error. This PR strips the remaining autocomplete code parts. Autocomplete features for advanced grid search fields have to be revisited and re-implemented using the api.

@guerler guerler changed the title Use former version of autocomplete module for grids Strip broken autocomplete feature, webbrowsers console error is an artifact Feb 27, 2017

@guerler guerler added status/review and removed status/WIP labels Feb 27, 2017

@galaxybot galaxybot added this to the 17.05 milestone Feb 27, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

@guerler What change was it when this stopped working?

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2017

At least since last year: https://github.com/galaxyproject/galaxy/blame/dev/templates/grid_base.mako#L105.
It is not a critical feature and I would prefer to revisit it in a consistent way at another time.

@dannon

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

Sorry, I meant the menu itself, what changed that broke between 17.01 and dev?

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2017

I enabled access to the regular jquery autocomplete module in #3407. The former use pattern for grids started to throw an exception on initialization after making the current autocomplete plugin available. The exception hinders the execution of the menu module.

@martenson

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

Seems like a decent solution to me. Thanks @guerler !

@martenson martenson merged commit 194fb1e into galaxyproject:dev Feb 28, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.