Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] fix tool search index building for tools with slash in id and not from TS #3680

Merged
merged 2 commits into from Feb 28, 2017

Conversation

Projects
None yet
5 participants
@martenson
Copy link
Member

commented Feb 28, 2017

No description provided.

@martenson martenson requested a review from mvdbeek Feb 28, 2017

slash_indexes = [ m.start() for m in re.finditer( '/', id ) ]
id_stub = id[ ( slash_indexes[1] + 1 ): slash_indexes[4] ]
if tool.guid:
# Crate a stub consisting of owner, repo, and tool from guid

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek Feb 28, 2017

Member

s/Crate/A crate of Staropramen, asap!/ 💯

@mvdbeek
Copy link
Member

left a comment

:shipit:

@galaxybot galaxybot added the triage label Feb 28, 2017

@jmchilton jmchilton merged commit e23facb into galaxyproject:release_17.01 Feb 28, 2017

4 checks passed

api test Build finished. 257 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

@bgruening bgruening deleted the martenson:fix-id-indexing branch Feb 28, 2017

@bgruening bgruening added this to the 17.05 milestone Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.