Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter hda tags for tool parameters #3688

Merged
merged 11 commits into from Mar 6, 2017

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Mar 1, 2017

This PR adds basic tag filtering options to tool form select fields without changing the ui. ping @dannon

guerler added some commits Mar 2, 2017

@guerler guerler added status/review and removed status/WIP labels Mar 2, 2017

@guerler guerler requested a review from dannon Mar 2, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Mar 3, 2017

My initial reading of this is that for large histories this will fire off hundreds or thousands of new database queries per tool form load. I'd encourage you to profile this and verify. I'd recommend updating .active_datasets_and_roles to prefetch tags as well if you are going to use them in this way.

In some cases the tags won't be needed (for deleted datasets, datasets that don't match the matcher) but my initial intuition having previously profiled this code path is that on balance it will usually be a lot faster to fetch the extra information than going back over and over for it.

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2017

@galaxybot test this

@dannon dannon merged commit 6b2f9be into galaxyproject:dev Mar 6, 2017

2 of 5 checks passed

api test Test scheduled.
Details
framework test Test scheduled.
Details
toolshed test Test scheduled.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
@dannon
Copy link
Member

left a comment

Functions well, we just need to add some UI hints and feedback now. Similarly to how matched parts of the name are underlined, people need to know they're matching against a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.