Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium Testing Improvements #3716

Merged
merged 2 commits into from Mar 7, 2017

Conversation

Projects
None yet
5 participants
@jmchilton
Copy link
Member

commented Mar 6, 2017

  • Initial collection builders tests to start working on test cases for #3696.
  • Improved exception messages for more tests to help with tracking down problems with remaining transient test failures.
Implement initial collection builder UX test cases.
Exercise list and paired builder's most basic functionality.
@@ -14,6 +15,7 @@


class HasDriver:
TimeoutException = TimeoutException

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 6, 2017

Member

Is that needed?

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 6, 2017

Member

I guess because it's used as self.TimeoutException in NavigatesGalaxy subclass, sorry for the noise

This comment has been minimized.

Copy link
@jmchilton

jmchilton Mar 6, 2017

Author Member

I have avoided selenium imports in test/galaxy_selenium/navigates_galaxy.py and all of the test/selenium_tests files - this was required to to continue that. I didn't necessarily set out to do be so encapsulated - but it is a nice property to have now.

If you insist I will drop this and add a direct import of this class from navigates_galaxy.py.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 6, 2017

Member

That's fine.

Improved Selenium exception messages.
For many common waiting operations used throughout many tests:

```
TimeoutException: Message:
```

Will become something like

```
TimeoutException: Message: Timeout waiting on CSS selector [#dataset-adb5f5c93f827949.state-failed] to become visible.
```

For HID waiting I've added the state and HID as well - so something like this:

```
TimeoutException: Message: Failed waiting on history item 1 state to change to [ok] current state [failed]. Timeout waiting on CSS selector [#dataset-adb5f5c93f827949.state-failed] to become visible.
```

@jmchilton jmchilton force-pushed the jmchilton:selenium_uploads_0 branch from 422ad65 to 8800376 Mar 6, 2017

@dannon dannon merged commit 9ccb095 into galaxyproject:dev Mar 7, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Mar 26, 2019

This PR was merged without a 'kind/' tag, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.