Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook search overlay interfering with masthead load #3731

Merged
merged 4 commits into from Mar 10, 2017

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Mar 8, 2017

This removes the global toolform requirement which was breaking the masthead on some pages. New webhooks probably shouldn't be adding libraries at the toplevel, rather require()ing them when necessary. This is a quick fix that opts to use a redirect, which we can easily convert to routing when available, instead of the much heavier weight solution.

I also standardized tabs/spaces within the file, and cleaned up a bit (unused or global vars, etc)

@guerler This should fix the issue you saw.

@dannon dannon requested a review from guerler Mar 8, 2017

@dannon dannon changed the title Fix webhook search overlay Fix webhook search overlay interfering with masthead load Mar 8, 2017

@galaxybot galaxybot added the triage label Mar 8, 2017

@galaxybot galaxybot added this to the 17.05 milestone Mar 8, 2017

@guerler guerler merged commit 5a7eab0 into galaxyproject:dev Mar 10, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

@dannon dannon referenced this pull request May 4, 2017

Merged

Tool-Describing-Tours #4019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.