Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook plugin: tool_list #3753

Merged
merged 5 commits into from Mar 21, 2017

Conversation

Projects
None yet
5 participants
@blankclemens
Copy link
Contributor

commented Mar 14, 2017

Add a webhook plugin at masthead which creates a list of installed toolshed tools on this instance in YAML format. Users can then use it to create their own Galaxy instance or Galaxy Docker flavour based on the same tools.

@galaxybot galaxybot added the triage label Mar 14, 2017

@galaxybot galaxybot added this to the 17.05 milestone Mar 14, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Mar 14, 2017

I have no particular objection to merging this since it is optional - but if this is useful don't you think it should just be available in the admin menu somewhere?

@blankclemens

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2017

While it can be useful for admins as well, the initial thought was to provide it to non admin users. But I agree, thematically I would rather put it in some kind of "server information" page or likewise, e.g. something inside the user preferences (admin interface would fit better, but that again is restricted to admins).

I'd be willing to look into that if there are suggestions on where to put it (and how to present it).

blankclemens added some commits Mar 15, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Mar 19, 2017

While it can be useful for admins as well, the initial thought was to provide it to non admin users.

I agree with you, and this information is already available to non-admin users with a GET to api/tools.
We could probably work a bit on the formatting and the output style of the API so that you would just need to GET to api/tools.

Given that the webhooks are nicely isolated I'm happy to merge this.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Mar 20, 2017

@galaxybot test this

@jmchilton jmchilton merged commit 5428d39 into galaxyproject:dev Mar 21, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

Thank you for the contribution @blankclemens !

@blankclemens

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2017

Thanks @martenson , although it's the smallest possible start I guess.. but it's a start ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.