Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError when getting request and response content-type headers #3757

Merged
merged 1 commit into from Mar 15, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Mar 15, 2017

Fix #2551

Also fix Python3 compatibility, xref: #1715

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 15, 2017

+1, combined with the discussion on the related bioblend issue, this makes sense and I'll merge it when travis finishes. It looks like we already handled a 'default' content-type in subsequent logic, which would have been my only concern.

Could you separate bugfixes from python3 tweaks moving forward, though? For example, this PR would be two commits, ideally, for easier review (at least to me).

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 15, 2017

OSX builds look to be hung again, everything else ran successfully.

@dannon dannon merged commit 0e7a715 into galaxyproject:dev Mar 15, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:fix_for_2551 branch Mar 16, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

@dannon Thanks for the merge! I'll keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.