Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract uWSGI handling into new galaxy.web.stack package #3759

Merged
merged 2 commits into from Mar 20, 2017

Conversation

Projects
None yet
2 participants
@natefoo
Copy link
Member

commented Mar 15, 2017

No description provided.

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

Most of this looks great (and it seems to work fine in local testing).

The 'alt_wrap' bits are iffy to me, I think I'd probably rather have wrap_if_allowed return an indicator of success (maybe (app, success=True/False) or something). That, or maybe even raise an exception which we expect to catch and handle. What happens when we have three items? I'm thinking of the third interactive debugger option here, specifically

@natefoo

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2017

@dannon good suggestion, thanks, updated.

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 20, 2017

Thanks for incorporating the suggestion, tested again and it looks great. +1

@dannon dannon merged commit 5440889 into galaxyproject:dev Mar 20, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.