Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n improvements and French localization #3762

Merged
merged 33 commits into from Mar 23, 2017

Conversation

@dannon
Copy link
Member

commented Mar 16, 2017

S'il vous plaît aider si vous parlez français

A first attempt at expanding our localization usage, and implementing french language!

Coverage is spotty, but this is something we can work on.

Masthead:
image

Example of where we need more coverage:
image

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

Now with masthead support! (moved screenshot to the top)

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

👏

bebatut and others added some commits Mar 16, 2017

Merge pull request #10 from dannon/bebatut-patch-1
Correct some translation errors
@yvanlebras

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2017

👏

@abretaud

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2017

C'est formidable !

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

Sure, I can help!
But just one question, how many language do you plan to support?
Is it just for our famous bad skills in English? :P

Because as far as I know, I never met any French user stuck because they don't understand the user interface (They are because their bam are not sorted :/)

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

@lecorguille Right now we have Japanese, Chinese, and (as of this PR) French. I don't think we have a limit to the number of languages we want to support other than realizing that the core team certainly can't maintain (or even write them originally!) them all.

What we can do is implement a localization framework, and allow native speakers (as @bebatut fixed up the FR version a bit) do the translation as they are willing.

More concretely, the 'framework-side' work is the same for one language as it is for all languages. We just need the file client/galaxy/scripts/nls/fr/locale.js for each locale in question, which we can solicit help from the community to build/maintain. At worst, missing translations will fail through to English.

"Pages":
false,
"Visualization":
"Représentation des données",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 16, 2017

Member

J'aurais gardé Visualisation ou hybride : Visualisation des données

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 17, 2017

Contributor

+1 for "Visualisation"

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

@dannon As long as you don't ask us to translate the different tool help section, I'm in!

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

Sounds good! If you want to fork https://github.com/dannon/galaxy/tree/i18n and PR any changes, feel free!

Next step for finishing off the translation is to change all the 'false' lines to contain the correct french version of the string. (and uncomment the commented ones, after providing the translation, of course)

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

@bebatut To not compete on that, are you currently doing it?

@bebatut

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

@lecorguille No. I am fighting with conda, g++ and openmpi :)

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

@dannon I think I'm at the edge of my limit about GitHub... How can I fork your project if I already have a fork of galaxy?

@bgruening

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

@lecorguille you can do something like this:

git checkout -b dannon-i18n dev
git pull https://github.com/dannon/galaxy.git i18n
@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

If you already have a fork, something like this:

git remote add dannon
git checkout -b i18n dannon/i18n
<make changes>
git push -u <your fork, probably 'origin'> i18n

And then issue a PR

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

(or what bjoern said! too many ways to do things :))

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

Oh, finally, I was not at my limit. I'm just tried :/
I knew the answer
Ok, allons-y !

@yvanlebras

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2017

Related to your sentence @lecorguille

Is it just for our famous bad skills in English? :P

Because as far as I know, I never met any French user stuck because they don't understand the user interface (They are because their bam are not sorted :/)

My new job until september is to challenge the use of Galaxy to give access to data and tools to citizen scientists.... and we need to have something written in French for some users (ie citizen/naturalists). I have an intern who will specifically challenge Galaxy on this point + other things related to GUI customization.... This PR is a superb opportunity to work deeper on that. If the "Galaxy challenge" become a success, it will be possible to have dedicated fundings to maintain this kind of improvement...

@dannon dannon added status/review and removed status/WIP labels Mar 17, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2017

Ready for review I think?

There is a ton more we can localize, but this gets the masthead and a lot more of the history panel. Still need to do more tooltips, etc., but those can be separate PRs.

Thanks a ton to @yvanlebras, @lecorguille, and @bebatut for the translations!

"Hide datasets" :
"Cacher les jeux de données",
"Unhide datasets" :
"Restaurer les jeux de données cachés",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

"Restaurer" -> "Afficher"

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

Yes, this is better!

"Permanently delete datasets" :
"Supprimer définitivement les jeux de données",
"This will permanently remove the data in your datasets. Are you sure?" :
"Cela supprimera de manière permanente les données de votre historique. Êtes-vous certains?",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

"Êtes-vous certains?" -> "Êtes-vous certains ?"

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

+1

This comment has been minimized.

Copy link
@nagoue

nagoue Mar 19, 2017

Contributor

Hi, this should be : "Êtes-vous certain ?"


// // ---- history-view-annotated
"Dataset" :
"Jeu de données",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

We should be agree before the merge about Dataset transalation.
If you really want "Jeu de données", can you sync the first part?

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

I think "jeu de données" is a better translation for "dataset" but maybe this can be context dependent..


// ---- history-view-edit-current
"This history is empty. Click 'Get Data' on the left tool menu to start" :
"Cet historique est vide. Cliquer sur 'Téléverser des données' au niveau du menu d'outils à gauche pour démarrer",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

'Get Data', I guess will not be translated.
So, IMHO, it's confusing!

This comment has been minimized.

Copy link
@dannon

dannon Mar 17, 2017

Author Member

Yeah, this is a sticky one. Let me see what I can do about "Get Data", since it's so high profile. We certainly won't be able to do all tools, but maybe this section.

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

+1 to translate at least this section and thus modify here the "Get data" statement.

"Vous n'avez pas la permission de voir ce jeu de données",
// state: discarded
"The job creating this dataset was cancelled before completion" :
"Le calcul ayant créé ce jeu de données a été annulé prématurément",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

Proposition: "Le calcul ayant créé ce jeu de données" -> "Le processus à l'origine de ce jeu de données"

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

Really better! Thanks

"Les métadonnées sont auto-détectées",
// state: running
"This job is currently running" :
"Le traitement est en cours",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

The same, we should choose for job between: Traitement, Calcul and Processus
I like Traitement

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

Sure! Once again, this seems context dependent I think... So maybe we can't always translate with the same french Word. ...

"Undelete dataset to edit attributes" :
"Restaurer le jeu de données pour en éditer les attributs",
"This dataset must finish uploading before it can be edited" :
"Ce jeu de données doit être entièrement téléversé avant avant toute modification",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

"avant avant" -> "avant"

"Delete" :
"Supprimer",
"Dataset is already deleted" :
"Pov' tâche, le jeu de données est déjà supprimé ;)",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

Vu :)
J'avais pensé à une contrepèterie mais je suis cul

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

Oeil de lynx ;)

This comment has been minimized.

Copy link
@dannon

dannon Mar 21, 2017

Author Member

Just to confirm, this is fine as written, correct? :)

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek Mar 23, 2017

Member

Well, it translates more or less to dumbass, the dataset is already deleted. We could be a bit friendlier here ;),
"Le jeu de données est déjà supprimé ;)" would be fine.

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 23, 2017

Member

Oups, I forgot to fix this!

This comment has been minimized.

Copy link
@dannon

dannon Mar 23, 2017

Author Member

No worries, all resolved now!

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 23, 2017

Contributor

A ba bravo ;) first proposition was better I think but majority have voted !

"Le traitement est en cours",
// state: paused
"This job is paused. Use the \"Resume Paused Jobs\" in the history menu to resume" :
"Ce traitement est en pause. Utilisez le \"Relancer les traitements en pause\" dans le menu d'historique pour le relancer",

This comment has been minimized.

Copy link
@lecorguille

lecorguille Mar 17, 2017

Member

"Resume Paused Jobs" is not currently translated :/

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 18, 2017

Contributor

Same as for "Get Data"... If "Resume Paused Jobs" will be translated, thus we will update this statement I think

This comment has been minimized.

Copy link
@dannon

dannon Mar 21, 2017

Author Member

"Get Data" is more difficult and I think I'll wait until a second pass, but I'm adding "Resume Paused Jobs" and the rest of that menu now.

This comment has been minimized.

Copy link
@dannon

dannon Mar 21, 2017

Author Member

@lecorguille @yvanlebras I added more translation points in 54af197 though unfortunately not for "Get Data" yet -- that one's more complicated and I'll want to address it in a future PR. If you guys want to fill in those, we can swap "Resume Paused Jobs", etc.

This comment has been minimized.

Copy link
@yvanlebras

yvanlebras Mar 23, 2017

Contributor

Thanks!

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2017

Looks like the translation for 'search datasets' is a bit long:
image

Is there a shorter way to say this?

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

Yvan and its commit integration :/
What I proposed: "Rechercher des données"

@galaxybot galaxybot added this to the 17.05 milestone Mar 17, 2017

@dannon dannon changed the title i18n work i18n improvements and French localization Mar 21, 2017

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 22, 2017

@dannon and @yvanlebras
I can propose something today about Add more translation points for localization.

@ValentinChCloud

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2017

Hi everyone . I'm Yvan's trainee, may I help you with this translation job? I'm a bit a newbie on github, if errors are made, tell me. I can start on @lecorguille suggestion.

lecorguille and others added some commits Mar 22, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2017

@ValentinChCloud I just saw your other PR, sorry! I think this pass is pretty much done now, but we can identify the next places we'll want to improve. Feel free to ping me on IRC (or Gitter) to talk about what you might be able to do next!

@ValentinChCloud

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2017

@dannon no worries ! Moreover I pulled it on galaxyproject the first time ... Thanks ,I will do it .

@lecorguille

This comment has been minimized.

Copy link
Member

commented Mar 22, 2017

What a success!
@ValentinChCloud The next one is for you :)

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 23, 2017

Thanks all!

@martenson martenson merged commit 9e807da into galaxyproject:dev Mar 23, 2017

4 checks passed

api test Build finished. 267 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.