Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layered routing fix for when controller route fails and client route does not exist. #3783

Merged

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Mar 20, 2017

This changes to only attempting to resolve a client route when the mapper has a hit.

Just hit something like the following route to see the problem and test:
http://localhost:8080/history/sl23904824

@dannon dannon requested a review from guerler Mar 20, 2017

@galaxybot galaxybot added this to the 17.05 milestone Mar 20, 2017

@dannon dannon removed the request for review from guerler Apr 5, 2017

@jmchilton jmchilton merged commit c27dac6 into galaxyproject:dev Apr 5, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2017

Thanks @jmchilton!

@jmchilton

This comment has been minimized.

Copy link
Member

commented Apr 5, 2017

Of course @dannon - thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.