Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom builds mako #3794

Merged
merged 51 commits into from Apr 5, 2017

Conversation

Projects
None yet
6 participants
@guerler
Copy link
Contributor

commented Mar 21, 2017

This PR replaces the custom build mako with a backbone view and corresponding API endpoints.

dbbuild

guerler added some commits Mar 13, 2017

@bgruening

This comment has been minimized.

Copy link
Member

commented Mar 28, 2017

Thanks @guerler for working on this!

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2017

Thanks @bgruening. I have not used this feature very often and would appreciate if someone could help me test these changes. ping @jennaj

@jennaj

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

@guerler I can test, feedback in a bit

@nsoranzo nsoranzo requested a review from jennaj Mar 29, 2017

@jennaj

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

Works great and updated styling is nice.

All functions on the GC form itself worked (and quickly)

Function choices: Fa from history, Len pasted, and Len uploaded all create proper CGs

  • listed correctly on the CG form, edit attributes genome list, upload genome list (therefore can be assigned as database metadata)
  • can be used with trackster for visualization

The prior link for "Show loaded, system-installed builds" is no longer there, but it was a function that needed some tunings to make the info really useful (searchable list, instead of raw text blob). Maybe was removed on purpose?

Let me know if you need more done. Thanks!

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2017

Thanks a lot for the quick review @jennaj. The 'system-installed builds' are shown in a searchable list if any are installed otherwise the search field is hidden.

@guerler guerler added status/review and removed status/WIP labels Mar 29, 2017

@galaxybot galaxybot added this to the 17.05 milestone Mar 29, 2017

@@ -676,6 +679,127 @@ def set_communication(self, trans, id, payload={}, **kwd):
trans.sa_session.flush()
return {'message': message}

@expose_api
def get_custom_builds_metadata(self, trans, id, payload={}, **kwd):
""" Returns meta data for custom builds. """

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 29, 2017

Member

Can you please add some documentation to the new API calls (like the one create(), update() and delete() methods have)?

This comment has been minimized.

Copy link
@guerler

guerler Mar 29, 2017

Author Contributor

Yes, of course, thanks for pointing it out @nsoranzo

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

(talking through API changes with @guerler offline, review in progress)

@dannon dannon merged commit a16c532 into galaxyproject:dev Apr 5, 2017

4 checks passed

api test Build finished. 271 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented Apr 5, 2017

Thanks for making those API adjustments for me, looks good now.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Apr 5, 2017

And also thanks for the API docs @guerler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.