Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bedfile display in trackster #3822

Merged
merged 2 commits into from Mar 27, 2017

Conversation

Projects
None yet
6 participants
@hrhotz
Copy link
Contributor

commented Mar 27, 2017

using the lagacy python environemnt is also required for "CONVERTER_bed_to_fli_0" when displaying a bed file in trackster

Update __init__.py
using the lagacy python environemnt is also required for "CONVERTER_bed_to_fli_0" when displaying a bed file in trackster

@mvdbeek mvdbeek changed the base branch from dev to release_17.01 Mar 27, 2017

@mvdbeek mvdbeek changed the base branch from release_17.01 to dev Mar 27, 2017

@galaxybot galaxybot added the triage label Mar 27, 2017

@@ -131,6 +131,7 @@
"CONVERTER_maf_to_fasta_0",
"CONVERTER_maf_to_interval_0",
"CONVERTER_wiggle_to_interval_0",
"CONVERTER_bed_to_fli_0",

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek Mar 27, 2017

Member

I think those are mostly alphabetic, could you move this line just below "# Converters" ?

This comment has been minimized.

Copy link
@hrhotz

hrhotz Mar 27, 2017

Author Contributor

I have changed it

@galaxybot galaxybot added this to the 17.05 milestone Mar 27, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

@hrhotz Thanks for the immediate action. We'll also need to backport this to 17.01.

@martenson martenson changed the title Update __init__.py fix bedfile display in trackster Mar 27, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

I'll open a PR to backport and add CONVERTER_gff_to_fli_0 to the list as well.

@jmchilton jmchilton merged commit a6240c4 into galaxyproject:dev Mar 27, 2017

2 of 5 checks passed

api test Test scheduled.
Details
framework test Test scheduled.
Details
toolshed test Test scheduled.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Mar 27, 2017

Fix CONVERTER_gff_to_fli_0 for striping Galaxy from Python environment.
Taking another stab at fixing galaxyproject#3499 which was broken with galaxyproject#3364. Last attempt at fixing converters didn't cover this (galaxyproject#3690) but I missed this tool and bed to fli fixed in galaxyproject#3822.
@jennaj

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

When on main, please ping me and I'll integration test/close out these related tickets. Thanks all for the fixes!

@hrhotz hrhotz deleted the hrhotz:patch-1 branch Mar 28, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

@jennaj this is on Main now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.