Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for EtherCalc IE image specification. #3825
Mar 28, 2017
5 checks passed
I'm not completely sure about this. The visualization tab view of GIEs (i.e. allowed_images) is more focused on multiple dataset selection. Ethercalc can't support loading N datasets currently, so moving it there might be a mistake as people might try to select multiple files and expect those to be available.
(Or maybe I'm forgetting how GIEs work in 17.05? and allowed_images is now required?)
EtherCalc didn't appear at all for selection from a dataset in history or the IE tab, under a default GIE setup (simple localhost:8080 with node proxy) after copying the .ini, until I made the
Also, FWIIW, while the App loads, it always has an empty spreadsheet.
@blankenberg that's odd, it appeared for me under datasets in history during PR testing. Maybe we have changed that and I haven't been following along.
It shouldn't have an empty spreadsheet when running under not localhost. I'm looking into those issues, but they didn't seem to be ethercalc issues, more with how we're launching notebooks and passing env vars which configure the galaxy helper clients in the container.
Ah, yes, I have one of the handful of configurations that will cause a failure for get() but not put(): running on localhost (so not DNS addressable) + X-Sendfile.
@blankenberg can you perhaps elaborate on your setup?
Hmm, it still works for me without this fix as well ..odd that it's not even appearing in the list for you, having
Empty spreadsheets are not surprising when starting it from the launcher, it would require some changes to the docker image to properly load datasets selected by the user in this way, which I would be happy to make, but as @erasche pointed out it cannot handle multiple datasets currently, so I didn't enable it to work with the launcher.