Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Order processing evaluation of workflow invocations when scheduling. #3830

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Mar 28, 2017

So history maintains more order by default.

xref #3820 (comment)

I'd say this is a usability bug so I'm targeting 17.01. Happy to switch to dev if this is considered an enhancement instead by anyone.

Ping @bgruening @guerler

@@ -4000,7 +4000,7 @@ def poll_active_workflow_ids(

query = sa_session.query(
WorkflowInvocation
).filter( and_( *and_conditions ) )
).filter( and_( *and_conditions ) ).order_by( WorkflowInvocation.table.c.id.asc() )

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 28, 2017

Member

Wouldn't it be faster to just select the workflow invocation ids?

This comment has been minimized.

Copy link
@jmchilton

jmchilton Mar 28, 2017

Author Member

Why yes - this would be much faster. Give me a second...

[17.01] Order processing evaluation of workflow invocations when sche…
…duling.

xref #3820 (comment)

Also optimize the query to just pull out workflow invocation IDs per the suggestion of @nsoranzo [here](#3830 (review)).

@jmchilton jmchilton force-pushed the jmchilton:1701_order_collection_invocation_processing branch from 947fb56 to 5d3250f Mar 28, 2017

@bgruening

This comment has been minimized.

Copy link
Member

commented Mar 28, 2017

👍 thanks!

@dannon dannon merged commit bf6b65f into galaxyproject:release_17.01 Mar 31, 2017

5 checks passed

api test Build finished. 257 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.