Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter checks for GFF/GFF3/GTF sniffing #3832

Merged
merged 2 commits into from Mar 30, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Mar 28, 2017

  • Check frame column in Gff.sniff() and Gtf.sniff() .
  • Parse attributes column in Gff3.sniff() with a specific function to prevent non-compliant GTF files being recognised as GFF3.
  • Fix import order for lib/galaxy/datatypes/util/gff_util.py .

nsoranzo added some commits Mar 28, 2017

Stricter checks for GFF/GFF3/GTF sniffing
Check frame column in Gff.sniff() and Gtf.sniff() .
Parse attributes column in Gff3.sniff() with a specific function to prevent
non-compliant GTF files being recognised as GFF3.

@nsoranzo nsoranzo added this to the 17.05 milestone Mar 28, 2017

@dannon dannon merged commit 90ac2f4 into galaxyproject:dev Mar 30, 2017

5 checks passed

api test Build finished. 271 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.