Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Fix for direct message routing using a 'real' exchange like rabbitmq #3846

Merged
merged 1 commit into from Apr 9, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Mar 29, 2017

This worked with local/database connections already, if accidentally. I want to do more refactoring of how these are configured, but am deferring that for now as it's not a priority.

@martenson This probably resolves that issue you were seeing with the installer, as well.

Fix for direct message routing using a 'real' exchange like rabbitmq …
…-- this worked with local/database connections already, if accidentally. I want to do more refactoring of how these are configured, but am deferring that for now as it's not a priority.

@dannon dannon requested a review from natefoo Mar 29, 2017

@dannon dannon changed the base branch from dev to release_17.01 Mar 29, 2017

@dannon dannon changed the title Fix for direct message routing using a 'real' exchange like rabbitmq … [17.01] Fix for direct message routing using a 'real' exchange like rabbitmq … Mar 29, 2017

@dannon dannon changed the title [17.01] Fix for direct message routing using a 'real' exchange like rabbitmq … [17.01] Fix for direct message routing using a 'real' exchange like rabbitmq Mar 29, 2017

@dannon dannon removed the request for review from natefoo Apr 5, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2017

Removed requested reviewers. Anyone welcome to review.

@martenson martenson merged commit 2396bef into galaxyproject:release_17.01 Apr 9, 2017

5 checks passed

api test Build finished. 257 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Apr 9, 2017

This PR was merged without a milestone attached.

@nsoranzo nsoranzo added this to the 17.05 milestone Apr 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.