Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Fix collection operations in workflows. #3848

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Mar 30, 2017

Due to a couple bugs things weren't being delayed correctly for some of these tools in some workflows.

Adds a test case that previously would have failed. The test workflow uses the "filter failed" collection operation tool in the middle of the workflow to kill off dead branches of computation - and continue the workflow only with the OK datasets in the collection.

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2017

Moving to WIP - this API test failure is legitimate.

@jmchilton jmchilton added status/WIP and removed status/review labels Mar 30, 2017

[17.01] Fix collection operations in workflows.
Due to a couple bugs things weren't being delayed correctly for some of these tools in some workflows.

@jmchilton jmchilton force-pushed the jmchilton:collection_operation_check_inputs_bug branch from f2378b4 to 8e0be50 Apr 3, 2017

@jmchilton jmchilton added status/review and removed status/WIP labels Apr 3, 2017

@@ -48,7 +48,7 @@ def execute_single_job(params):
burst_at = getattr( config, 'tool_submission_burst_at', 10 )
burst_threads = getattr( config, 'tool_submission_burst_threads', 1 )

tool_action = tool.action
tool_action = tool.tool_action

This comment has been minimized.

Copy link
@bgruening

bgruening Apr 8, 2017

Member

mh, yes this is really confusing. tool.action also exists.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Apr 21, 2017

Author Member

Agreed this is confusing - probably addressing that is beyond the scope of this PR I think.

@martenson martenson merged commit 7e4f805 into galaxyproject:release_17.01 Apr 25, 2017

5 checks passed

api test Build finished. 261 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 27 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.