Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Fix multiple collection reductions on multiple data parameters. #3875

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Apr 5, 2017

Was introduced in #805 but there was a small bug (maybe a last minute change before opening the PR?) in the client code so this never was exposed to the users the way it was intended.

This should largely negate the need for hacks such as in cuffmerge that allow multiple list collections in addition to main multiple data selector. xref galaxyproject/tools-iuc#1225.

xref #750 as well.

Fix multiple collection reductions on multiple data parameters.
Was introduced in #805 but there was a small bug (maybe a last minute change before opening the PR) in the client code so this never was exposed to the users the way it was intended.

This should largely negate the need for hacks such as in cuffmerge that allow multiple list collections in addition to main multiple data selector. xref galaxyproject/tools-iuc#1225.

@jmchilton jmchilton force-pushed the jmchilton:fix_multi_collection_multi_data_param_reductions branch from 7c79ab3 to 9234420 Apr 5, 2017

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2017

@galaxybot test this

@bgruening

This comment has been minimized.

Copy link
Member

commented Apr 8, 2017

👍

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

Stupid bug. 😿

@martenson martenson merged commit 02bdc74 into galaxyproject:release_17.01 Apr 25, 2017

5 checks passed

api test Build finished. 260 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 27 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.