Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inability for viz to raise loading with non-ascii messages #3881

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
3 participants
@erasche
Copy link
Member

commented Apr 5, 2017

Found whilst working with @ValentinChCloud debugging GIEs. We could not see the error since their OS produced a non-ascii message.

@@ -766,13 +767,13 @@ def _handle_plugin_error( self, trans, visualization_name, exception ):
"""
Log, raise if debugging; log and show html message if not.
"""
log.exception( 'error rendering visualization (%s): %s', visualization_name, str( exception ) )
log.exception( 'error rendering visualization (%s): %s', visualization_name, unicodify( exception ) )

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Apr 6, 2017

Member
log.exception( 'error rendering visualization (%s)', visualization_name )

should be enough since the exception info is logged anyway by log.exception() .

This comment has been minimized.

Copy link
@erasche

erasche Apr 13, 2017

Author Member

Sorry, didn't notice this coment

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

@erasche If you drop the parameter from log.exception as mentioned by @nsoranzo (https://docs.python.org/2/library/logging.html#logging.Logger.exception automatically appends), does it print correctly?

@erasche

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2017

Yep, looks good. Remove extraneous string.

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

@erasche Awesome, thanks!

@dannon dannon merged commit d21c8dc into galaxyproject:dev Apr 13, 2017

0 of 5 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
toolshed test Test started.
Details
@nsoranzo

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

Thanks @erasche!

@erasche erasche deleted the erasche:unicode-viz-errors branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.