Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show default value for runtime values #3943

Merged

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Apr 19, 2017

Instead of displaying an empty field and requiring the user to explicitly enter a value for runtime values, this PR displays the input parameters default value instead. ping @arbernard.

@guerler guerler added this to the 17.05 milestone Apr 19, 2017

@arbernard

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2017

Great to read that you have managed to fix this issue and that Galaxy 17.05 will include it, thank you @guerler ! :D

@guerler guerler added status/review and removed status/WIP labels Apr 22, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

Sorry for missing this sooner - this is a really good idea. Awesome work!

@jmchilton jmchilton merged commit 291426a into galaxyproject:dev Apr 27, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Build finished. 274 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.