Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin style values for color picker element #3965

Merged
merged 5 commits into from Apr 25, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Apr 24, 2017

No description provided.

guerler added some commits Apr 24, 2017

@guerler guerler removed the minor label Apr 24, 2017

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

@galaxybot test this

@guerler guerler added status/review and removed status/WIP labels Apr 24, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

@guerler Would it simplify this to use :first-child, :last-child, instead of manually setting classes for those content elements?

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

Thanks @dannon, good point.

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

@guerler Thanks for the modifications, looks nice!

@dannon dannon merged commit 399c7f0 into galaxyproject:dev Apr 25, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Test started.
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.