Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour fixes #3970

Merged
merged 3 commits into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
@nsoranzo
Copy link
Member

commented Apr 25, 2017

  • Fix some selectors
  • Remove unnecessary quotes that end up in the pop-up
  • Fix one pop-up title
  • Remove one step that is broken if the user is already logged-in
  • Do not click on the section name, it is already expanded

nsoranzo added some commits Apr 21, 2017

More fixes for History Intro tour
- Remove unnecessary quotes that end up in the pop-up
- Fix one pop-up title
- Remove one step that is broken if the user is already logged-in

@nsoranzo nsoranzo added this to the 17.05 milestone Apr 25, 2017

@nsoranzo nsoranzo requested a review from dannon Apr 25, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

@nsoranzo I'll run through these in a few to test, thanks for giving them a look! Most of the changes here make sense, but I'm curious about the client rebuild -- this shouldn't be necessary and is commonly caused by differing nodejs environments.

@nsoranzo nsoranzo force-pushed the nsoranzo:tour_fixes branch from 0857691 to feb3168 Apr 25, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2017

@dannon Thanks for pointing this out, I was under the impression it was necessary and I've uselessly wasted time and CPU doing make client while testing this!
It's fixed now.

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

@nsoranzo Thanks for the change, this looks good to me!

@dannon dannon merged commit 2b05fd0 into galaxyproject:dev Apr 25, 2017

2 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Test started.
Details
framework test Test started.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:tour_fixes branch Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.