Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Remote user logout fixes, rework header handling a bit. #3976

Merged
merged 5 commits into from Apr 26, 2017

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Apr 25, 2017

@erasche This should hopefully fix your issues from #3581, works in my local testing, let me know how it goes for you.

dannon added some commits Apr 11, 2017

@erasche

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

Yes!! This looks like it does it.

galaxy.web.framework.middleware.remoteuser DEBUG 2017-04-26 00:34:57,708 Discarding invalid remote user header HTTP_CAS_USER:(null)@tamu.edu.
galaxy.web.framework.middleware.remoteuser DEBUG 2017-04-26 00:34:57,717 Discarding invalid remote user header HTTP_CAS_USER:(null)@tamu.edu.

awesome :D 👍

@erasche erasche added this to the 17.05 milestone Apr 26, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

@dannon Still WIP?

@dannon

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

@nsoranzo Nope, should be good to go, let me relabel it now.

@dannon dannon added status/review and removed status/WIP labels Apr 26, 2017

@nsoranzo nsoranzo merged commit f3c134a into galaxyproject:release_17.01 Apr 26, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Build finished. 261 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 27 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.