Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying a message instead of just redirecting #4000

Merged
merged 1 commit into from May 1, 2017

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

commented May 1, 2017

…on clientside routes when login is required. TODO: refactor both message display and the decoration of routes.

Quick fix for displaying a message instead of just redirecting on cli…
…entside routes when login is required. TODO: refactor both message display and the decoration of routes.

@dannon dannon added the status/review label May 1, 2017

@dannon dannon requested a review from guerler May 1, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 1, 2017

(just wanted to get this in before freeze so login-required routes behave better -- refactoring coming, but don't hold release for it)

@galaxybot galaxybot added this to the 17.09 milestone May 1, 2017

@dannon dannon changed the title Quick fix for displaying a message instead of just redirecting on cli… Displaying a message instead of just redirecting May 1, 2017

@dannon dannon modified the milestones: 17.05, 17.09 May 1, 2017

@guerler guerler merged commit edff1e6 into galaxyproject:dev May 1, 2017

2 of 5 checks passed

api test Test started.
Details
framework test Test started.
Details
toolshed test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Copy link
Member

commented May 1, 2017

4000 issues/pull requests!

@martenson

This comment has been minimized.

Copy link
Member

commented May 1, 2017

@nsoranzo since May 2015 I think. 2000/year. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.