Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling main_panel switching in various Selenium tests. #4003

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented May 2, 2017

PR #3992 fixed "with self.main_panel()" so that leaving the context actually restore the Selenium context back to the top level page. This surfaced a bunch of bugs related to assertions that were operating in the main panel without declaring it. This fixes those and makes the assertions a bit stronger - such as verifying error messages being asserted about are visible.

Fix handling main_panel switching in various Selenium tests.
PR #3992 fixed "with self.main_panel()" so that leaving the context actually restore the Selenium context back to the top level page. This surfaced a bunch of bugs related to assertions that were operating in the main panel without declaring it. This fixes those and makes the assertions a bit stronger - such as verifying error messages being asserted about are visible.

@jmchilton jmchilton added this to the 17.09 milestone May 2, 2017

@martenson martenson merged commit 53eff63 into galaxyproject:dev May 5, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to jmchilton/galaxy that referenced this pull request May 8, 2017

One more fix for main_panel fix in galaxyproject#3992.
See galaxyproject#4003 / d09ba53 for similar fix to other tests and more information.

@nsoranzo nsoranzo deleted the jmchilton:selenium_fixes_11 branch Jun 14, 2018

@nsoranzo nsoranzo added the kind/bug label Jun 14, 2018

@galaxyproject galaxyproject deleted a comment from galaxybot Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.