Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Fix setting up explicit container resolution... #4020

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented May 4, 2017

... from a container resolution config file.

@jmchilton jmchilton added this to the 17.05 milestone May 4, 2017

message = template % ( plugin_type, str( plugins_dict.keys() ) )
raise Exception( message )

plugin = plugin_klazz( **plugin_kwds )

This comment has been minimized.

Copy link
@bgruening

bgruening May 5, 2017

Member

plugin_klazz is not defined if the KeyError exception is raised, isn't it?

This comment has been minimized.

Copy link
@jmchilton

jmchilton May 5, 2017

Author Member

If the KeyError is raised - I raise a new more informative exception so the code would never reach this point.

This comment has been minimized.

Copy link
@bgruening
@bgruening

This comment has been minimized.

Copy link
Member

commented May 5, 2017

👍

@martenson martenson merged commit 0bafd68 into galaxyproject:release_17.05 May 12, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.