Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Fixes for containerized job executions. #4033

Merged
merged 2 commits into from May 12, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented May 5, 2017

A pair of framework related commits from my exploits in getting Kubernetes to run biocontainer jobs.

  • One commit fixes the docker_dispatch dynamic rule to respect BioContainers. It should have been updated with #2986 but wasn't and so would only detect containers explicitly annotated in tools.
  • Other commit prevents tools that require the legacy Python environment from being executed in BioContainers - at least for now. Galaxy isn't available in these Docker containers - there is no assurance Python is even available.
@bgruening

This comment has been minimized.

Copy link
Member

commented May 5, 2017

👍

@martenson martenson merged commit 185c766 into galaxyproject:release_17.05 May 12, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented May 12, 2017

Cooli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.