Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some test tools for collection job failures. #4044

Merged
merged 2 commits into from May 16, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented May 9, 2017

xref #4032

These at least verify that jobs are properly failing whether they use dynamic dataset collection or not. In the case of pre-determinable list structures - they properly go red and expose the problems to the user (try running test/functional/tools/collection_creates_list_fail.xml manually). In the case of dynamic dataset collections - this does not occur though - all the resulting datasets are indeed green.

Add some test tools for collection job failures.
xref #4032

These at least verify that jobs are properly failing whether they use dynamic dataset collection or not. In the case of pre-determinable list structures - they properly go red and expose the problems to the user (try running test/functional/tools/collection_creates_list_fail.xml manually). In the case of dynamic dataset collections - this does not occur though - all the resulting datasets are indeed green.
<tool id="collection_creates_list_fail" name="collection_creates_list_fail" version="0.1.0">
<command detect_errors="exit_code"><![CDATA[
#for $key in $list_output.keys()#
echo "identifier is $key" > "$list_output[$key]";

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo May 9, 2017

Member

Indentation.

@martenson

This comment has been minimized.

Copy link
Member

commented May 16, 2017

I added the requested indentation @nsoranzo however I checked at cheetah tutorial and it seems they do not use indentation this way there

@nsoranzo

This comment has been minimized.

Copy link
Member

commented May 16, 2017

Thanks @jmchilton and @martenson!

@nsoranzo nsoranzo merged commit ff30262 into galaxyproject:dev May 16, 2017

5 checks passed

api test Build finished. 276 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the jmchilton:collection_job_failure_tests branch May 16, 2017

@galaxyproject galaxyproject deleted a comment from galaxybot Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.