Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for new locales, rebuild of client. #4050

Merged
merged 2 commits into from May 10, 2017

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

commented May 10, 2017

(this fixes the client build)

@nsoranzo

This comment has been minimized.

Copy link
Member

commented May 10, 2017

@dannon Any clue about the failed qunit tests?

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 10, 2017

Yeah, pushing a fix as soon as the client build finishes.

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 10, 2017

(side note, it'd be great to 'make client' with a standard environment prior to running tests -- that's why this wasn't caught in the initial PR)

@anuprulez

This comment has been minimized.

Copy link
Member

commented May 10, 2017

Can this PR for locales fix be merged as the checks are successful? Thanks :)

@bgruening bgruening merged commit 70cc3eb into galaxyproject:dev May 10, 2017

5 checks passed

api test Build finished. 276 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented May 10, 2017

Thanks @dannon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.