Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Correct webhooks to use Galaxy.root and be compatible with proxy_prefix #4065

Merged
merged 3 commits into from May 16, 2017

Conversation

Projects
None yet
3 participants
@erasche
Copy link
Member

commented May 13, 2017

Fix #4064

Should this target 17.05? Not sure where the team is on release process there.

@erasche erasche added this to the 17.09 milestone May 13, 2017

@erasche erasche requested a review from bgruening May 13, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented May 14, 2017

@erasche yes, target 17.05 please; and thanks for fixing this

@bgruening bgruening changed the base branch from dev to release_17.05 May 14, 2017

@bgruening bgruening changed the base branch from release_17.05 to dev May 14, 2017

@erasche erasche changed the title Correct webhooks to use Galaxy.root and be compatible with proxy_prefix [17.05] Correct webhooks to use Galaxy.root and be compatible with proxy_prefix May 14, 2017

@erasche erasche changed the base branch from dev to release_17.05 May 14, 2017

@erasche erasche force-pushed the erasche:fix-4064 branch from 6e434a0 to 6dd145e May 14, 2017

@erasche erasche modified the milestones: 17.05, 17.09 May 14, 2017

@erasche

This comment has been minimized.

Copy link
Member Author

commented May 14, 2017

@martenson done

@martenson martenson merged commit 6614e94 into galaxyproject:release_17.05 May 16, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented May 16, 2017

Thank you @erasche !

@erasche erasche deleted the erasche:fix-4064 branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.