Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Fix global grid action event handler #4068

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented May 15, 2017

This PR fixes the event handler for global grid operations. To test this click on the 'Saved Pages' and try to create a new page. There is a second location in this module which already handles it correctly for operations in the same way as done here now.

@guerler guerler added this to the 17.05 milestone May 15, 2017

@guerler guerler changed the title Fix global grid action event handler [17.05] Fix global grid action event handler May 15, 2017

@guerler guerler added status/review and removed status/WIP labels May 15, 2017

@dannon dannon merged commit bd83608 into galaxyproject:release_17.05 May 15, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented May 15, 2017

Looks good to me.

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2017

Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.