Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Tag fixes #4139

Merged
merged 5 commits into from Jun 2, 2017

Conversation

Projects
None yet
6 participants
@dannon
Copy link
Member

commented Jun 1, 2017

  1. makes order consistent in hashtag display by sorting
  2. fixes one non-uniqued hashtag display (initial render of hda -- rerender fixed this which is why we never noticed before)
  3. filters empty tags in PJA (workflow editor tag application), fixes #4127
  4. allows hashtag usage in PJA tag box, fixes #4128

Mentioned in c260e0b commit, but the hashtag rendering templates/functions should be refactored and consolidated. I'll do this in dev, though, not 17.05.

@dannon dannon referenced this pull request Jun 1, 2017

Open

History "hastag" improvements/issues #3730

9 of 12 tasks complete
@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 1, 2017

Looks good to me. General question, can this kind of sorting, unique also be handled in the backend more efficiently?
👍

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2017

@bgruening It could be done in the manager, though I don't think it'd be any more efficient really. Since it's purely a display thing (and fairly cheap, at that) the client made more sense to me.

@guerler guerler merged commit 0272e18 into galaxyproject:release_17.05 Jun 2, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Jun 2, 2017

This PR was merged without a milestone attached.

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 2, 2017

@guerler we need to put 17.09 here or else it wouldn't appear in any release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.