Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Hide error highlighting if user interacts with highlighted field #4147

Merged
merged 2 commits into from Jun 4, 2017

Conversation

Projects
None yet
3 participants
@martenson
Copy link
Member

commented Jun 2, 2017

ThisPR is a proper version of #4143 that I broke with wrong merge. Doing a separate PR for clarity. Sorry @guerler :(

Fixes #4131. If an input field is highlighted with an error message in run tool forms (regular and workflow) the error message persists until another execution attempt has been made, even if the user updates the field value. This can be confusing. This PR resolves this by removing the error message if the field value changes after highlighting. The value is revalidated upon execution.

guerler added some commits Jun 1, 2017

@guerler

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2017

No worries. (:

@dannon dannon merged commit cbe9944 into galaxyproject:release_17.05 Jun 4, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the martenson:fix_hide_error branch Jun 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.