Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider enhancement, shared event listeners #4149

Merged
merged 12 commits into from Jun 7, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Jun 5, 2017

This PR aligns the slider implementation to other input elements by properly using the shared model structure. The benefit is that change events can be listened to by e.g. the input wrappers when showing/hiding error highlighting as implemented in #4147. It also introduces test cases and resolves a minor bug. Previously it was possible to paste floating values into integer fields through copy-and-paste.

@guerler guerler force-pushed the guerler:slider_upgrade branch from c19277e to 7274bb6 Jun 5, 2017

@guerler guerler added status/review and removed status/WIP labels Jun 6, 2017

@dannon dannon merged commit d75cec1 into galaxyproject:dev Jun 7, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.