Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move galaxy.tools.toolbox.cache to galaxy.tools.cache. #4155

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Jun 6, 2017

galaxy.tools.toolbox is shared with galaxy-lib and so should have no dependencies on sqlalchemy. Also this really seems to be caching tools and tool shed repositories and fairly independent of the toolbox abstraction so I think it is solid refactoring independent of the sqlalchemy/galaxy-lib constraints.

Ping @mvdbeek - any problems with this?

Move galaxy.tools.toolbox.cache to galaxy.tools.cache.
galaxy.tools.toolbox is shared with galaxy-lib and so should have no dependencies on sqlalchemy. Also this really seems to be caching tools and tool shed repositories and fairly independent of the toolbox abstraction so I think it is solid refactoring independent of the sqlalchemy/galaxy-lib constraints.
@mvdbeek

mvdbeek approved these changes Jun 6, 2017

Copy link
Member

left a comment

Yes, that makes a lot of sense!

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

@galaxybot test this

@dannon

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

Makes sense to me.

@dannon dannon merged commit fae508b into galaxyproject:dev Jun 6, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.