Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes mako for datasets grid #4163

Merged
merged 11 commits into from Jun 12, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Jun 7, 2017

This PR transforms the datasets grid such that it is built from JSON instead of mako/html.

@guerler guerler added this to the 17.09 milestone Jun 7, 2017

@guerler guerler added status/review and removed status/WIP labels Jun 7, 2017

@guerler guerler referenced this pull request Jun 7, 2017

Merged

Remove histories grid mako #4167

@guerler guerler requested review from dannon and nsoranzo Jun 10, 2017

@dannon dannon merged commit b25bf59 into galaxyproject:dev Jun 12, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@@ -83,6 +83,7 @@ window.app = function app( options, bootstrapped ){
'(/)user(/)(:form_id)' : 'show_user_form',
'(/)workflow(/)' : 'show_workflows',
'(/)pages(/)(:action_id)' : 'show_pages',
'(/)datasets(/)(:action_id)' : 'show_datasets',

This comment has been minimized.

Copy link
@dannon

dannon Jun 12, 2017

Member

I went ahead and merged this to keep moving along, but we don't use the :action_id at all in the routing function below, so /datasets/foo/ goes to /datasets/list/ as well, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.