Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Apart from these actions, the PR also moves the link to open Configure Workflow view to User Preferences. The Api calls to update the workflow items list in the Tool Panel remains with the Workflow's Api.
Thanks a lot to @bgruening
@guerler Thanks a lot for your help in fixing the bug related to the subsequent load of tools, datasets with a huge workflow (50+ steps) loaded in the center panel.
All suggestions are welcome!
Yeah this looks great to me. Can you do a performance test by checking how the UI behaves if you load the run workflow form multiple times with workflows containing 50+ steps and without reloading the entire page? Does the UI slow down? If not I think this is good to go.
@guerler I looked into it and have a couple of observations. I created a workflow with 60+ steps and made 3-4 copies.
I am able to load run workflow multiple times as each load of run workflow (for different workflow) automatically refreshes the page. But, when I try to load any tool from the left panel with 60+ steps workflow already loaded in the center panel, I get an unresponsive script error which does not happen if I load any tool (like AXT_TO_LAV) with a smaller workflow (say with 10 steps) already loaded in the center panel.
This error I get:
I am looking into the issue. One difference we have now is that we are displaying run workflow in the center-panel section of the Galaxy's middle part and just the needed
The selected tool's form loads but in about 2 mins which is unacceptable. The same issue is there with history items. May be all the links which open in the iframe.
Update: When a huge workflow is loaded in the center panel and any tool is clicked, the following line in
By this way, eventually that tool gets loaded in the
When I replaced this line by:
the tools gets loaded instantly but the page refreshes and it is loaded into the
Do you think this kind of solution is feasible or we should try to open the run workflow in the iframe itself? Because previously, run workflow was opening in the iframe. There did not seem to be any problem even with huge workflow.