Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Hashtags w/ workflow-defined tags fix #4188

Merged

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

commented Jun 13, 2017

Instead of setting the tags from a list, workflow PJAs will now append tags, so propagating tags will work alongside this feature.

This should fix the comments from @chambm and @yvanlebras here: #3730 (comment)

Instead of setting the tags from a list, workflow PJAs will now appen…
…d tags, so propagating tags will work alongside this feature.

@dannon dannon added status/WIP and removed status/review labels Jun 13, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2017

(testing a few edge cases)

@dannon dannon added status/review and removed status/WIP labels Jun 13, 2017

@chambm

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

This seems to be working for me (cherry-picked onto release_17.05). Thanks!

@jmchilton jmchilton merged commit fc613d2 into galaxyproject:release_17.05 Jul 5, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

Sorry this got lost in the run up to the GCC @dannon - this is a great fix and is really appreciated!

@galaxybot

This comment has been minimized.

Copy link

commented Jul 5, 2017

This PR was merged without a milestone attached.

@nsoranzo nsoranzo added this to the 17.09 milestone Jul 5, 2017

@dannon dannon referenced this pull request Sep 15, 2017

Open

History "hastag" improvements/issues #3730

9 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.